Skip to content

Development of text spotting code #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rwood-97 merged 16 commits into from
Dec 19, 2024
Merged

Development of text spotting code #536

rwood-97 merged 16 commits into from
Dec 19, 2024

Conversation

@rwood-97
Copy link
Collaborator

@rwood-97 rwood-97 commented Nov 27, 2024 •
edited
Loading

Summary

This PR adds some development to the text spotting code:

  • Adds dataclasses for text predictions
  • Relatively minor refactoring
  • Adds saving text predictions as centroid when calling save_to_geojson
  • Adding loading/saving of predictions

Fixes #504
Fixes #498
Addresses #533

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Update changelog
  • Ensure submission passes current tests
  • Add tests
  • Update relevant docs

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

@codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.33279% with 47 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
mapreader/spot_text/runner_base.py 79.55% 46 Missing ⚠️
mapreader/spot_text/dptext_detr_runner.py 83.33% 1 Missing ⚠️
Flag Coverage Δ
unittests 78.98% <92.33%> (+1.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
mapreader/spot_text/dataclasses.py 100.00% <100.00%> (ø)
mapreader/spot_text/deepsolo_runner.py 82.14% <100.00%> (ø)
mapreader/spot_text/maptext_runner.py 82.75% <100.00%> (ø)
tests/test_text_spotting/test_deepsolo_runner.py 100.00% <100.00%> (ø)
tests/test_text_spotting/test_dptext_runner.py 100.00% <100.00%> (ø)
tests/test_text_spotting/test_maptext_runner.py 100.00% <100.00%> (ø)
mapreader/spot_text/dptext_detr_runner.py 88.46% <83.33%> (-1.10%) ⬇️
mapreader/spot_text/runner_base.py 79.41% <79.55%> (+9.36%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rwood-97 rwood-97 mentioned this pull request Dec 10, 2024
Open
kallewesterling
kallewesterling suggested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@kallewesterling kallewesterling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, with suggestions of a few things to change here. Nothing major - looks great otherwise!!! :)

@rwood-97 rwood-97 merged commit 914ab59 into main Dec 19, 2024
9 checks passed
@rwood-97 rwood-97 deleted the text_dev branch December 19, 2024 18:23
@kmcdono2 kmcdono2 added the text on maps Integrating text detection and recognition task(s) label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kallewesterling kallewesterling kallewesterling approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

text on maps Integrating text detection and recognition task(s)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add method for loading predictions into runners Add polygon to centroid option to text spotting

4 participants

@rwood-97 @kallewesterling @kmcdono2